Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add policy-controller #348

Merged
merged 1 commit into from
Dec 7, 2023
Merged

re-add policy-controller #348

merged 1 commit into from
Dec 7, 2023

Conversation

maleck13
Copy link
Collaborator

This is re-adding the policy-controller.

This was verified here
#293

@maleck13 maleck13 requested a review from a team as a code owner November 30, 2023 07:34
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #348 (9922dad) into main (b736a7b) will decrease coverage by 0.87%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   65.42%   64.55%   -0.87%     
==========================================
  Files          35       35              
  Lines        3800     3800              
==========================================
- Hits         2486     2453      -33     
- Misses       1122     1146      +24     
- Partials      192      201       +9     
Flag Coverage Δ
integration 69.09% <ø> (-1.64%) ⬇️
unit 59.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.33% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 69.09% <ø> (-1.64%) ⬇️

see 4 files with indirect coverage changes

@maleck13 maleck13 self-assigned this Dec 1, 2023
@alexsnaps alexsnaps added this to the v0.6.0 milestone Dec 4, 2023
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Quickly validated the basic install as in original PR and see both containers running.

@maleck13 maleck13 merged commit bb6c189 into main Dec 7, 2023
21 checks passed
@didierofrivia didierofrivia deleted the gh-639-policy-controller branch December 7, 2023 11:07
maleck13 added a commit to maleck13/kuadrant-operator that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants