Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve steps format #383

Merged
merged 1 commit into from
Dec 18, 2023
Merged

improve steps format #383

merged 1 commit into from
Dec 18, 2023

Conversation

maleck13
Copy link
Collaborator

rendering as a single line in docs. So addd some new lines to space out the steps

@maleck13 maleck13 requested a review from a team as a code owner December 18, 2023 10:29
@maleck13
Copy link
Collaborator Author

@guicassolato minor formatting change to improve rendering in docs site

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #383 (e87b77e) into main (0355953) will decrease coverage by 0.51%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   65.87%   65.37%   -0.51%     
==========================================
  Files          35       35              
  Lines        3795     3795              
==========================================
- Hits         2500     2481      -19     
- Misses       1109     1122      +13     
- Partials      186      192       +6     
Flag Coverage Δ
integration 71.02% <ø> (-0.94%) ⬇️
unit 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 71.02% <ø> (-0.94%) ⬇️

see 7 files with indirect coverage changes

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maleck13 maleck13 merged commit d475858 into main Dec 18, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants