Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kuadrant CR finalizer #538

Merged
merged 1 commit into from
Apr 11, 2024

fix kuadrant CR finalizer

23537c8
Select commit
Loading
Failed to load commit list.
Merged

fix kuadrant CR finalizer #538

fix kuadrant CR finalizer
23537c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 11, 2024 in 0s

80.94% (+0.73%) compared to ece13e8

View this Pull Request on Codecov

80.94% (+0.73%) compared to ece13e8

Details

Codecov Report

Merging #538 (23537c8) into main (ece13e8) will increase coverage by 0.73%.
Report is 32 commits behind head on main.
The diff coverage is 40.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   80.20%   80.94%   +0.73%     
==========================================
  Files          64       71       +7     
  Lines        4492     4964     +472     
==========================================
+ Hits         3603     4018     +415     
- Misses        600      639      +39     
- Partials      289      307      +18     
Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 88.81% <100.00%> (-2.62%) ⬇️
pkg/common (u) 83.01% <ø> (-5.81%) ⬇️
pkg/istio (u) 75.14% <100.00%> (+1.23%) ⬆️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.84% <ø> (+0.39%) ⬆️
controllers (i) 77.27% <81.96%> (+0.47%) ⬆️
Files Coverage Δ
controllers/kuadrant_controller.go 49.81% <40.00%> (-3.76%) ⬇️

... and 16 files with indirect coverage changes