[UtilitiesBundle] Code improvement found by static code analysis

Kunstmaan · May 21, 2019 · ff332ac · ff332ac
1 parent 6cc410f
commit ff332ac
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/Helper/Cipher/UrlSafeCipher.php b/Helper/Cipher/UrlSafeCipher.php
@@ -50,13 +50,13 @@ public function hex2bin($hexString)
     {
         $pos = 0;
         $result = '';
-        while ($pos < strlen($hexString)) {
+        while ($pos < \strlen($hexString)) {
             if (strpos(" \t\n\r", $hexString[$pos]) !== false) {
                 ++$pos;
             } else {
                 $code = hexdec(substr($hexString, $pos, 2));
                 $pos += 2;
-                $result .= chr($code);
+                $result .= \chr($code);
             }
         }
 

diff --git a/Helper/ClassLookup.php b/Helper/ClassLookup.php
@@ -18,7 +18,7 @@ class ClassLookup
      */
     public static function getClass($object)
     {
-        return ($object instanceof Proxy) ? get_parent_class($object) : get_class($object);
+        return ($object instanceof Proxy) ? get_parent_class($object) : \get_class($object);
     }
 
     /**
@@ -30,7 +30,7 @@ public static function getClass($object)
      */
     public static function getClassName($reference)
     {
-        $reference = is_string($reference) ? $reference : ClassLookup::getClass($reference);
+        $reference = \is_string($reference) ? $reference : self::getClass($reference);
         $className = explode('\\', $reference);
 
         return array_pop($className);

diff --git a/Helper/Shell/Shell.php b/Helper/Shell/Shell.php
@@ -36,7 +36,7 @@ public function isRunning($pid)
     {
         exec("ps $pid", $processState);
 
-        return count($processState) >= 2;
+        return \count($processState) >= 2;
     }
 
     /**

diff --git a/Tests/unit/DependencyInjection/Compiler/DeprecateClassParametersPassTest.php b/Tests/unit/DependencyInjection/Compiler/DeprecateClassParametersPassTest.php
@@ -5,7 +5,6 @@
 use Kunstmaan\UtilitiesBundle\DependencyInjection\Compiler\DeprecateClassParametersPass;
 use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractCompilerPassTestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Definition;
 
 class DeprecateClassParametersPassTest extends AbstractCompilerPassTestCase
 {

diff --git a/Twig/UtilitiesTwigExtension.php b/Twig/UtilitiesTwigExtension.php
@@ -26,9 +26,9 @@ public function __construct($slugifier)
      */
     public function getFilters()
     {
-        return array(
+        return [
             new \Twig_SimpleFilter('slugify', [$this, 'slugify']),
-        );
+        ];
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,7 +36,7 @@ public function isRunning($pid) @@
         {
             exec("ps $pid", $processState);
-            return count($processState) >= 2;
+            return \count($processState) >= 2;
         }
         /**
@@ Expand Down @@