-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paper acknowledgement form #3637
Conversation
Hey sorry I have guests over I will try to give it a look in the evening, what is the context for this? is it required as part of the paper submission? |
It's not required, no. But it would be nice to acknowledge contributors. So it's not a super stress, but we should get it going in the next days. |
Would it make sense to allow the users to change their user name, and then make the leaderboard public? with all users with more than 0 points? |
we could do that as well, but for a lot of people I think it would be cool to see their name listed in a published paper. |
Oh, of course, that was my intention as well, my proposal was to read from the leaderboards, but I guess we would need consent and a "real" name anyway, so no problem. I took the liberty of cleaning up some stuff so it is not a "hack" anymore, I hope you are fine with that Although the database changes are not the best, it is not a problem since they should be only temporary. Please note: we still use
So adding columns is okay, migrations still not there yet, even though I added something in #3488, it was never merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, nice.
I know all of this is suboptimal, but I'd like to get people to sign up to be mentioned asap. Feel free to improve (or to tell me how to improve) now or in subsequent PRs. I anticipate this form will be going away in the future, so I'm not sure a lot of work will be really worth it.