Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make aws condition value explicit #193

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

Gadam8
Copy link
Contributor

@Gadam8 Gadam8 commented Aug 30, 2024

About the PR

The value of the AWS condition is currently set to AsyncApiAny. This is too open-ended and makes it difficult for the user to parse and use the value when parsing AsyncApi files. This PR sets the structure for condition and makes it explicit, which will make using the value on the other side more simple.

Changelog

  • Update: Set an explicit value for AWS condition

Related Issues

N/A

@VisualBean
Copy link
Collaborator

Note that this is technically a breaking change, but as it is limited to the bindings package, i think we can let it slide.

@Gadam8
Copy link
Contributor Author

Gadam8 commented Sep 2, 2024

Note that this is technically a breaking change, but as it is limited to the bindings package, i think we can let it slide.

Okay I see. I can amend the PR to be a feat if easier?

@VisualBean
Copy link
Collaborator

Note that this is technically a breaking change, but as it is limited to the bindings package, i think we can let it slide.

Okay I see. I can amend the PR to be a feat if easier?

I don't think that is needed in this case.
There is no need for it to show up in the changelog.

chore or refactor is fine 👍

@VisualBean
Copy link
Collaborator

Approved. Glad to see us moving closer to the truth, by implementing explicit classes for things, rather than the other way around (y)

@VisualBean VisualBean merged commit 030d603 into LEGO:main Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants