DrawDB task #2
Open
DrawDB task #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloem
reviewed
Nov 13, 2024
|
|
||
| vars: | ||
| github_repo: "https://github.com/LIDSOL/drawdb.git" | ||
| app_dir: "/app" |
There was a problem hiding this comment.
esto corre como root? tal vez sea mejor si utilizas /tmp/app para no tener que crear un directorio nuevo en la raiz del filesystem (/). Que piensas?
| state: present | ||
| when: ansible_distribution == "Debian" | ||
| tags: | ||
| - 1 |
There was a problem hiding this comment.
has utilizado los tags a la hora de ejecutar el playbook? normalmente los tags son un string que ayuda a filtrar pasos del notebook. Si no los has utilizado, tal vez sea mejor quitarlos
| repo: "{{ github_repo }}" | ||
| dest: "{{ app_dir }}" | ||
| force: yes | ||
| tags: |
There was a problem hiding this comment.
yo creo que conviene agregar un paso donde se borren estos archivos al final del playbook (asi podemos correrlo varias veces si es necesario). que piensas?
|
Igual no se que tan factible sea planear movernos con contenedores, al menos con la idea de estar hosteando a más largo plazo :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.