Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caliper top-down modifier #193

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Apr 3, 2024

No description provided.

@rfhaque rfhaque requested a review from pearce8 April 3, 2024 00:48
@github-actions github-actions bot added the configs New or modified system config label Apr 3, 2024
@pearce8
Copy link
Collaborator

pearce8 commented Apr 4, 2024

@rfhaque Can you please test on all x86 machines on-site we have defined in benchpark?

@rfhaque
Copy link
Collaborator Author

rfhaque commented Apr 4, 2024

@pearce8 Tested on quartz and pascal

@slabasan
Copy link
Collaborator

slabasan commented Apr 4, 2024

@rfhaque Can you include here how you turn on this caliper modifier? I just have --modifier=caliper, but will we need more specifics to select between top-down, cuda, etc?

@pearce8
Copy link
Collaborator

pearce8 commented Apr 5, 2024

We need to impose a constraint on the spack spec as this should only be used on Intel's x86. If a user tries to use this modifier on a different architecture, we should make sure they get an error indicating that the modifier does not work on this architecture. Doug provided this example: https://github.com/GoogleCloudPlatform/ramble/blob/develop/lib/ramble/ramble/language/modifier_language.py#L285

@rfhaque
Copy link
Collaborator Author

rfhaque commented Apr 5, 2024

in benchpark setup, we specify --modifier=caliper-topdown

@pearce8 pearce8 merged commit ee63482 into develop Apr 16, 2024
6 checks passed
@pearce8 pearce8 deleted the feature_caliper_topdown_modifier branch April 16, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs New or modified system config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants