Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rebuild docs on changes to bin/benchpark #216

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

alecbcs
Copy link
Member

@alecbcs alecbcs commented Apr 29, 2024

Adds a rule to rebuild the docs when bin/benchpark (or any future file in bin) changes in a PR.

Fixes #210

@github-actions github-actions bot added the ci Involving Project CI & Unit Tests label Apr 29, 2024
@pearce8 pearce8 self-requested a review April 29, 2024 19:46
Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alecbcs ./generate-benchmark-list.py $(WORKSPACE_PATH) is no longer outputting tags to our docs (see [] in our live docs https://software.llnl.gov/benchpark/benchmark-list.html). Can you take a look?

@alecbcs
Copy link
Member Author

alecbcs commented Apr 29, 2024

It looks like the docs lists are empty because benchpark tag is broken after #190.

@alecbcs
Copy link
Member Author

alecbcs commented Apr 29, 2024

Fixed errors in bin/benchpark in #217.

@pearce8 pearce8 merged commit f2847e3 into LLNL:develop Apr 29, 2024
6 checks passed
@alecbcs alecbcs deleted the add/ci-bin-docs branch May 1, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Involving Project CI & Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update github actions to re-render docs when bin/benchpark is updated
3 participants