Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spack version #219

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Update spack version #219

merged 4 commits into from
Apr 30, 2024

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Apr 30, 2024

Update the spack version ussed by benchpark

@rfhaque rfhaque requested review from scheibelp and pearce8 April 30, 2024 19:15
pearce8
pearce8 requested changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scheibelp @alecbcs this PR appears to hit the same issue in CI that @rountree sees with his tests.

@rfhaque
Copy link
Collaborator Author

rfhaque commented Apr 30, 2024 •
edited
Loading

@pearce8 Is this a bug in the concretizer or is it due to spack having deprecated a specific cmake version

@scheibelp
Copy link
Collaborator

scheibelp commented Apr 30, 2024 •
edited
Loading

scheibelp alecbcs this PR appears to hit the same issue in CI that rountree sees with his tests.

You're talking about #207? That is a fetcher error, this appears to be a concretization error

Is this a bug in the concretizer or is it due to spack having deprecated a specific cmake version

If we are explicitly requesting [email protected], then that will fail with the latest spack (it was deprecated as of March 19 2024)

UPDATE: we are in fact requesting that version of cmake for saxpy right now: https://github.com/LLNL/benchpark/blob/develop/experiments/saxpy/openmp/ramble.yaml

@github-actions github-actions bot added the experiment New or modified experiment label Apr 30, 2024
@pearce8 pearce8 merged commit ea8293e into develop Apr 30, 2024
6 checks passed
@pearce8 pearce8 deleted the update_spack_version branch April 30, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearce8 pearce8 pearce8 approved these changes

@scheibelp scheibelp Awaiting requested review from scheibelp

Assignees
No one assigned
Labels
experiment New or modified experiment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfhaque @scheibelp @pearce8