Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamlining terminology in docs #240

Merged
merged 9 commits into from
May 26, 2024
Merged

Streamlining terminology in docs #240

merged 9 commits into from
May 26, 2024

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented May 8, 2024

Standardizing organization and naming of the subcomponents of Benchpark:

  • Benchmarks
  • System specifications (originally called system configs)
  • Experiments

Reorganizing how-to information into a set of FAQ sub-pages.

@github-actions github-actions bot added the docs Improvements or additions to documentation label May 8, 2024
@pearce8 pearce8 added this to the v0.1.1 milestone May 17, 2024
@pearce8 pearce8 linked an issue May 17, 2024 that may be closed by this pull request
@pearce8 pearce8 self-assigned this May 17, 2024
@pearce8 pearce8 requested a review from scheibelp May 17, 2024 03:58
@pearce8 pearce8 marked this pull request as ready for review May 17, 2024 04:01
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be worth putting the high-level intent in the PR description: at least one of the high-level goals seems to be standardizing organization and naming of the subcomponents of benchpark:

  • Benchmarks
  • System specifications (originally called system configs)
  • Experiments

Another appears to be reorganizing how-to information into a set of FAQ sub-pages (I have a comment that we might want to change the titles of these pages).

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
docs/add-a-site-specific-system-config.rst Outdated Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
docs/FAQ-benchpark-repo.rst Outdated Show resolved Hide resolved
@pearce8 pearce8 merged commit 43bd3b8 into develop May 26, 2024
7 checks passed
@pearce8 pearce8 deleted the docs/terminology branch May 26, 2024 19:00
slabasan added a commit that referenced this pull request Oct 19, 2024
slabasan added a commit that referenced this pull request Oct 19, 2024
pearce8 added a commit that referenced this pull request Oct 25, 2024
* docs: fix reference to current system specs

file renamed in #240

* first draft of workflow, lots of overlap with existing docs

* initial checkin of new docs

* still needs updates but the overall flow is there

* fix spelling error

* updated a few more files

* fix formatting

* few more docs updates

* more docs updates

* Update docs for allocation modifier

* added examples for experiment init

* updated workflow figure

* Some udpates to the validation steps

* benchmark validation steps

* updates site-specific configs

* fix formatting

* formatting fixes

* more udpates

* adding experiment instructions

* fix version check command

* rework table of contents, move legacy workflow to separate section

* Reorg and updates, system example needed, container, why benchpark

* typo in add a system

* update index order

* remove fugaku from main page

* a few updates

* updates to llnl tutorial

* make note internal

* System class: Adding Dane to CTS (#408)

* adding Dane to CTS

* add dryruns for all cts systems

* fix typo

* Bump actions/checkout from 4.2.1 to 4.2.2 (#409)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@eef6144...11bd719)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Print status messages about bootstrapping (#410)

Bootstrapping can take a while, provide some indication of activity
to the user.

* next up finish the x86 system example

* Full x86 example

* hide why benchpark page and fix typos

* another typo

* index cleanup

- remove benchpark-help page, merged into another page
- move benchmark suites page into running benchpark
- rename suite of experiments page

* fix unexpected indent warning

* remove bad reference to page that doesn't exist

* add a system: fix indent warning

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Stephanie Brink <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pearce8 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to document spack and ramble version pinning
2 participants