Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remhos gpu experiment #508

Merged
merged 27 commits into from
Jan 7, 2025
Merged

Remhos gpu experiment #508

merged 27 commits into from
Jan 7, 2025

Conversation

august-knox
Copy link
Collaborator

@august-knox august-knox commented Dec 18, 2024

Description

Adding rocm and cuda variants for remhos. Also includes Caliper annotations, and strong/weak scaling.

Dependencies: None

Fixes issue(s): None

Type of Change

  • { } Adding a system, benchmark, or experiment
  • {x} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • {x} Add a new dry run unit test in .github/workflows
  • {x} System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • {x} Configure an experiment
  • {x} Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • {x} Extend experiment.py under existing directory for specific benchmark
  • {x} Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added experiment New or modified experiment application New or modified application labels Dec 18, 2024
@pearce8
Copy link
Collaborator

pearce8 commented Jan 6, 2025

  • @rfhaque to run on Ruby
  • remove Caliper ifdef from remhos make file - this is in remhos repo
  • source code fix for allocation

@github-actions github-actions bot added the ci Involving Project CI & Unit Tests label Jan 7, 2025
@rfhaque rfhaque changed the title Remhos rocm experiment Remhos gpu experiment Jan 7, 2025
@august-knox august-knox marked this pull request as ready for review January 7, 2025 20:50
@rfhaque rfhaque requested a review from pearce8 January 7, 2025 21:19
@pearce8 pearce8 merged commit 87dd631 into develop Jan 7, 2025
8 checks passed
@pearce8 pearce8 deleted the experiment/remhosGPU branch January 7, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application New or modified application ci Involving Project CI & Unit Tests experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants