Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes minor typo that will cause CD to fail #137

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

ilumsden
Copy link
Collaborator

@ilumsden ilumsden commented Jun 7, 2024

Title says it all. I noticed that #136 didn't correctly update the version of the upload-artifact for sdists. This causes CD to fail. I also realized that I can test this on this PR by uncommenting the pull_request trigger. Please don't merge this until I have recommented it.

@ilumsden ilumsden added area-deployment Issues and PRs involving Hatchet's packaging and deployment priority-urgent Urgent priority issues and PRs status-work-in-progress PR is currently being worked on type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Jun 7, 2024
@ilumsden ilumsden requested review from pearce8 and dyokelson June 7, 2024 23:05
@ilumsden ilumsden self-assigned this Jun 7, 2024
@ilumsden ilumsden marked this pull request as ready for review June 7, 2024 23:52
@pearce8 pearce8 merged commit 5a24993 into LLNL:develop Jun 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-deployment Issues and PRs involving Hatchet's packaging and deployment priority-urgent Urgent priority issues and PRs status-work-in-progress PR is currently being worked on type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants