Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tuple as Argument to tree #139

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Allow tuple as Argument to tree #139

merged 1 commit into from
Jul 12, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

As found in an earlier Slack discussion: in order to provide a single column to GraphFrame.tree in a MultiIndex Thicket.statsframe (GraphFrame), this small change is necessary.

@michaelmckinsey1 michaelmckinsey1 added priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs area-visualization Issues and PRs involving any of the Hatchet provided visualizations labels Jun 18, 2024
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jun 18, 2024
ilumsden
ilumsden approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearce8 this is ready for your review

@ilumsden ilumsden added status-approved No more revisions are required on this PR and it is ready for merge and removed status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Jul 2, 2024
@pearce8 pearce8 merged commit 30f0758 into LLNL:develop Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilumsden ilumsden ilumsden approved these changes

@pearce8 pearce8 Awaiting requested review from pearce8

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-visualization Issues and PRs involving any of the Hatchet provided visualizations priority-normal Normal priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmckinsey1 @ilumsden @pearce8