Updated percentile.py to allow user defined percentiles, and separating calculated values into separate columns #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyM1098
added
area-stats
…values into seperate columns
slabasan
force-pushed
the
andrew_percentiles
branch
from
064ce74 to
feaef26
Compare
slabasan
force-pushed
the
andrew_percentiles
branch
from
4a3941c to
343f6d2
Compare
slabasan
approved these changes
Dec 22, 2023
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Mar 6, 2024
…ng calculated values into separate columns (LLNL#103) * Changed percentiles.py to take in custom values, and split calulated values into seperate columns * Updated doc string for function * Updated percentile.py to pass black and flake8 * Updating percentile unit testing * Updated formatting for unit testing * code cleanup * percentiles: add test for percentiles=None --------- Co-authored-by: Stephanie Brink <[email protected]>
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Mar 6, 2024
…ng calculated values into separate columns (LLNL#103) * Changed percentiles.py to take in custom values, and split calulated values into seperate columns * Updated doc string for function * Updated percentile.py to pass black and flake8 * Updating percentile unit testing * Updated formatting for unit testing * code cleanup * percentiles: add test for percentiles=None --------- Co-authored-by: Stephanie Brink <[email protected]>
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Mar 14, 2024
…ng calculated values into separate columns (LLNL#103) * Changed percentiles.py to take in custom values, and split calulated values into seperate columns * Updated doc string for function * Updated percentile.py to pass black and flake8 * Updating percentile unit testing * Updated formatting for unit testing * code cleanup * percentiles: add test for percentiles=None --------- Co-authored-by: Stephanie Brink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated percentile.py in order for the user to define what percentile values they would like calculated. If the user does not specify what percentile values to calculate, it uses the default values [.25, .50, .75].
Another fix made is that for each calculated percentile for each column, the calculated value is put into it's own separate column in the statistics frame with the format: column_percentiles_percentile instead of all the values in a list.