Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for Hatchet's "new-style" queries to Thicket #44

Closed
wants to merge 3 commits into from
Closed

Adds support for Hatchet's "new-style" queries to Thicket #44

wants to merge 3 commits into from

Conversation

ilumsden
Copy link
Collaborator

@ilumsden ilumsden commented Jun 9, 2023

This PR adds support for Hatchet's new-style queries to Thicket. More specifically, this PR adds the following:

  • A new thicket.query module that re-exports the Query Language classes and functions
  • Support for the object- and string-based dialects of the Query Language

The dialect support is enabled through the new multi_index_mode parameter. This parameter is currently being documented in LLNL/hatchet#90.

@ilumsden ilumsden requested a review from slabasan June 9, 2023 21:41
@ilumsden ilumsden self-assigned this Jun 9, 2023
@ilumsden ilumsden added area-query-lang Issues and PRs related to Thicket's support for Hatchet's query language priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features labels Jun 9, 2023
@ilumsden ilumsden added this to the 2023.2.1 milestone Jun 9, 2023
@ilumsden ilumsden force-pushed the new-style-queries branch 3 times, most recently from 62a4273 to f47a65a Compare June 9, 2023 21:56
@ilumsden ilumsden marked this pull request as draft June 9, 2023 23:34
@ilumsden ilumsden force-pushed the new-style-queries branch from 4554cee to 7a16206 Compare June 9, 2023 23:44
@ilumsden ilumsden removed this from the 2023.2.1 milestone Jun 14, 2023
slabasan
slabasan approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@slabasan slabasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I see it is still in draft mode. Is this ready for merge?

@slabasan
Copy link
Collaborator

slabasan commented Jul 1, 2023

@ilumsden Let me know if this one is no longer in draft mode.

@ilumsden
Copy link
Collaborator Author

ilumsden commented Jul 4, 2023

@slabasan there are still some things I need to fix to get things passing with unit tests. I also realized that this will only get the dialects working for Thickets without a column multi-index. That means things like columnar join Thickets aren't going to be supported yet.

@ilumsden ilumsden closed this Apr 23, 2024
@ilumsden ilumsden mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan slabasan approved these changes

Assignees

@ilumsden ilumsden

Labels
area-query-lang Issues and PRs related to Thicket's support for Hatchet's query language priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilumsden @slabasan