Clean up visibility for implementation classes in teh client

LMAX-Exchange · Nov 23, 2024 · 7c7ec66 · 7c7ec66
1 parent 0cb11c8
commit 7c7ec66
Show file tree

Hide file tree

Showing 23 changed files with 30 additions and 536 deletions.
diff --git a/client/build.gradle b/client/build.gradle
@@ -48,9 +48,9 @@ sourceSets {
 dependencies {
 
     // main dependencies
-    api 'com.fasterxml.jackson.core:jackson-databind:2.17.2'
-    api 'com.fasterxml.jackson.core:jackson-annotations:2.17.2'
-    api 'com.fasterxml.jackson.core:jackson-core:2.17.2'
+    implementation 'com.fasterxml.jackson.core:jackson-databind:2.17.2'
+    implementation 'com.fasterxml.jackson.core:jackson-annotations:2.17.2'
+    implementation 'com.fasterxml.jackson.core:jackson-core:2.17.2'
 
     // integration test dependencies
     integrationTestImplementation project(path: ':shared', configuration: 'sharedTestSupport')
@@ -108,7 +108,6 @@ tasks.processTestResources {
 check.dependsOn unitTest
 check.dependsOn integrationTest
 check.dependsOn checkstyleMain
-check.dependsOn checkstyleTest
 check.dependsOn checkstyleIntegrationTest
 
 javadoc {

diff --git a/client/src/main/java/com/lmax/solana4j/client/api/AddressTableLookup.java b/client/src/main/java/com/lmax/solana4j/client/api/AddressTableLookup.java
diff --git a/client/src/main/java/com/lmax/solana4j/client/api/BlockResponse.java b/client/src/main/java/com/lmax/solana4j/client/api/BlockResponse.java
diff --git a/client/src/main/java/com/lmax/solana4j/client/api/ProgramAccountResponse.java b/client/src/main/java/com/lmax/solana4j/client/api/ProgramAccountResponse.java
diff --git a/client/src/main/java/com/lmax/solana4j/client/api/SignatureInfo.java b/client/src/main/java/com/lmax/solana4j/client/api/SignatureInfo.java
diff --git a/client/src/main/java/com/lmax/solana4j/client/api/SimulateTransactionResponse.java b/client/src/main/java/com/lmax/solana4j/client/api/SimulateTransactionResponse.java
@@ -10,7 +10,7 @@ public interface SimulateTransactionResponse
 
     AccountInfoData getAccounts();
 
-    List<Instruction> getInnerInstructions();
+    List<InnerInstruction> getInnerInstructions();
 
     Blockhash getReplacementBlockhash();
 

diff --git a/client/src/main/java/com/lmax/solana4j/client/api/Transaction.java b/client/src/main/java/com/lmax/solana4j/client/api/Transaction.java
diff --git a/client/src/main/java/com/lmax/solana4j/client/jsonrpc/AccountInfoDataDTO.java b/client/src/main/java/com/lmax/solana4j/client/jsonrpc/AccountInfoDataDTO.java
@@ -15,7 +15,7 @@
 
 
 @JsonDeserialize(using = AccountInfoDataDTO.AccountInfoDataDeserializer.class)
-class AccountInfoDataDTO implements AccountInfoData
+final class AccountInfoDataDTO implements AccountInfoData
 {
     private final List<String> accountInfoEncoded;
     private final AccountInfoParsedData accountInfoParsed;

diff --git a/client/src/main/java/com/lmax/solana4j/client/jsonrpc/AccountKeysDTO.java b/client/src/main/java/com/lmax/solana4j/client/jsonrpc/AccountKeysDTO.java
@@ -14,12 +14,12 @@
 import java.util.List;
 
 @JsonDeserialize(using = AccountKeysDTO.AccountKeyDeserializer.class)
-public class AccountKeysDTO implements AccountKeys
+final class AccountKeysDTO implements AccountKeys
 {
     private final List<String> accountKeysEncoded;
     private final List<AccountKeyParsed> accountKeysParsed;
 
-    public AccountKeysDTO(final List<String> accountKeysEncoded, final List<AccountKeyParsed> accountKeysParsed)
+    AccountKeysDTO(final List<String> accountKeysEncoded, final List<AccountKeyParsed> accountKeysParsed)
     {
         this.accountKeysEncoded = accountKeysEncoded;
         this.accountKeysParsed = accountKeysParsed;
@@ -93,7 +93,7 @@ public String toString()
         }
     }
 
-    public static class AccountKeyDeserializer extends JsonDeserializer<AccountKeysDTO>
+    static class AccountKeyDeserializer extends JsonDeserializer<AccountKeysDTO>
     {
         @Override
         public AccountKeysDTO deserialize(final JsonParser parser, final DeserializationContext context) throws IOException

diff --git a/client/src/main/java/com/lmax/solana4j/client/jsonrpc/AddressTableLookupDTO.java b/client/src/main/java/com/lmax/solana4j/client/jsonrpc/AddressTableLookupDTO.java
diff --git a/client/src/main/java/com/lmax/solana4j/client/jsonrpc/BalanceDTO.java b/client/src/main/java/com/lmax/solana4j/client/jsonrpc/BalanceDTO.java
@@ -5,7 +5,7 @@
 import com.lmax.solana4j.client.api.Context;
 import com.lmax.solana4j.client.api.SolanaRpcResponse;
 
-public final class BalanceDTO implements SolanaRpcResponse<Long>
+final class BalanceDTO implements SolanaRpcResponse<Long>
 {
     private final ContextDTO context;
     private final Long value;