Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCNM] Add final Waking the Beast BCNM fight (Carbuncle Prime) #6257

Draft
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

TracentEden2
Copy link
Contributor

@TracentEden2 TracentEden2 commented Sep 18, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Note this is still a draft (to get feedback) as a few details are still being verified on retail. (This includes verification of the potency formula of Healing Ruby II (when used by carbuncle mobs) and the distance range of avatar 2hrs) And also better to wait for the other WTB PRs to be merged.

This PR is part of a series to add the full Waking the Beast quest. This PR adds the final Carbuncle Prime BCNM in Full Moon Fountain. This is a complex fight consists of 7 different stages. The logic is mostly concentrated in the battlefield script in onBattlefieldTick (and private helper functions) as coordination is needed to, for example, spawn and despawn multiple mob groups (during phase changes) and facilitate mobs using simultaneous 2hrs. This centralized logic is better than having the logic distributed across many mob scripts which would add complexity and reduce understandability.

The fight logic and flow is based on many captures including by Siknoz (here and here), Aether (here), and KnowOne (here).

Also the PR includes one small core change: adding a setSpawnAnimation function so that the elemental avatars can be spawned with their special spawn animations (as on retail).

Steps to test these changes

Fight the BCNM and compare to retail captures

@TracentEden2 TracentEden2 changed the title [BCNM] Add final waking the beast BCNM fight (Carbuncle Prime) [BCNM] Add final Waking the Beast BCNM fight (Carbuncle Prime) Sep 18, 2024
@TracentEden TracentEden force-pushed the add_carby_wtb_bcnm branch 3 times, most recently from 3068e6a to 495f8b5 Compare September 18, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants