[lua] Port ASB JoL #6312
[lua] Port ASB JoL #6312
Conversation
|
Drafting for CI |
WinterSolstice8
force-pushed
the
port_ASB_JoL
branch
from
e9d2c46 to
dabd2d7
Compare
WinterSolstice8
force-pushed
the
port_ASB_JoL
branch
2 times, most recently
from
07c3731 to
c62bd4e
Compare
| [5] = 5029, -- Ltng List | ||
| [6] = 5030, -- Water List | ||
| [7] = 5024, -- Light List | ||
| [8] = 5031, -- Dark List |
There was a problem hiding this comment.
This indexes are xi.element.NAME
We will need to make sure this IDs are defined in the DB aswell
There was a problem hiding this comment.
updated to use real spell lists
|
|
||
| -- Animations, action IDs and elemental absorb mods are directly mapped to eachother per retail caps | ||
| -- in the "standard" order, Fire Ice Wind Earth Thunder Water Holy Dark | ||
| local eleAbsorbModID = { 459, 460, 461, 462, 463, 464, 465, 466 } |
There was a problem hiding this comment.
This concrete line is unnecesary, I think. We have the element table inside combat folder for them, following the same elemental order
There was a problem hiding this comment.
removed and replaced wit the combat definition
| end | ||
|
|
||
| entity.onMobFight = function(mob, target) | ||
| -- reduce regen after nine Xzomits and Hpemdes are killed | ||
| mob:setAnimationSub(2) |
There was a problem hiding this comment.
This seems weird. This would mean we are constantly setting its animationSub. We are already doing that onMobEngaged and I dont see it being changed anywhere else
There was a problem hiding this comment.
Commented for now, but leaving in as a note for myself when I test
This thing is fully featured and complete (I've fought it several times on Horizon and the final changes to make it retail accurate for the skill swaps/animations (packet stuff) were from me) There's also one bug that I intend to fix (standback doesn't work correctly for JoL, but that will come in a later commit) |
WinterSolstice8
force-pushed
the
port_ASB_JoL
branch
10 times, most recently
from
59fd769 to
2345b98
Compare
| if pet and pet:isAlive() then | ||
| pet:timer(1500, function(petArg) | ||
| if petArg:getFamily() == 269 then -- xzomit | ||
| petArg:useMobAbility(786) -- lateral slash |
There was a problem hiding this comment.
We have enums for these now, can you at these there please?
There was a problem hiding this comment.
done (this made me look into the fact that Xzomits were told to use a tonberry move. it looks like this section is guessed -- as far as I know, nobody has gotten a capture with JoL using Astral Flow with an xzomit up)
WinterSolstice8
force-pushed
the
port_ASB_JoL
branch
5 times, most recently
from
16074a9 to
87d221f
Compare
-- It was hard to figure out who did what on which file so I just blanket added anyone who sorta looked like they worked on these files -- Co-authored-by: Frankie-hz <[email protected]> Co-authored-by: Kravy <[email protected]> Co-authored-by: WinterSolstice8 <[email protected]> Co-authored-by: TracentEden <[email protected]>
WinterSolstice8
force-pushed
the
port_ASB_JoL
branch
from
87d221f to
67cd3a4
Compare
I affirm:
What does this pull request do?
Backports a more functional JoL from ASB
Steps to test these changes
Fight JoL, see eveything is normal