Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch quorum parameters from edasm at RBN instead of latest block #190

Merged

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Oct 24, 2024

Fixes Issue

Think this is a bug... but not 100% sure. So please verify that this is correct.

Fixes #

Changes proposed

Screenshots (Optional)

Note to reviewers

@samlaf samlaf requested review from epociask and bxue-l2 October 24, 2024 16:35
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is more future proofing then a current bug fix since these thresholds are hardcoded into the EigenDAServiceManagerStorage contract

@samlaf
Copy link
Collaborator Author

samlaf commented Oct 24, 2024

LGTM - this is more future proofing then a current bug fix since these thresholds are hardcoded into the EigenDAServiceManagerStorage contract

Ah gotcha then I need to update the comment I wrote.

@samlaf samlaf merged commit e233047 into main Oct 24, 2024
7 checks passed
@samlaf samlaf deleted the samlaf/bug--fetch-quorum-info-at-rbn-instead-of-latest-block branch October 24, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants