Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#191): Routing namespace --> Storage #195

Merged
merged 6 commits into from
Oct 31, 2024
Merged

fix(#191): Routing namespace --> Storage #195

merged 6 commits into from
Oct 31, 2024

Conversation

epociask
Copy link
Collaborator

Fixes Issue

Fixes #191

Changes proposed

  • Removed routing flag category in favor of storage
  • Created deprecated flag category for routing
  • Introduce store config struct with CLI flags and cfg invariants declared in /store package

Screenshots (Optional)

Note to reviewers

@epociask epociask requested review from samlaf and bxue-l2 October 28, 2024 02:26
samlaf
samlaf reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Have a few minor nits

common/store.go Outdated Show resolved Hide resolved
store/generated_key/memstore/memstore.go Show resolved Hide resolved
store/cli.go Outdated Show resolved Hide resolved
flags/eigendaflags/deprecated.go Outdated Show resolved Hide resolved
store/cli.go Outdated Show resolved Hide resolved
store/deprecated_flags.go Show resolved Hide resolved
@epociask epociask requested a review from samlaf October 29, 2024 06:46
samlaf
samlaf approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epociask epociask merged commit f263439 into main Oct 31, 2024
7 checks passed
@epociask epociask deleted the epociask--fix-191-store-cfg branch October 31, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flags: Change routing to storage
2 participants
@epociask @samlaf