fix(middleware): proper handling of handler status codes in log/metrics middlewares #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epociask
reviewed
Nov 19, 2024
server/middleware.go
Outdated
| // we assume that every route will set the status header | ||
| recordDur(w.Header().Get("status"), string(mode), string(versionByte)) | ||
| return fmt.Errorf("metrics middleware: error parsing version byte: %w", err) | ||
| // Some routes don't have a version byte, such as /put simple commitments. |
There was a problem hiding this comment.
why would /put simple commitments not have a version byte but OP /put would?
There was a problem hiding this comment.
Good catch.... I was totally wrong here. I updated to: 096003c
Realized our version bytes are hardcoded for all the PUT routes.. bit ugly how I did some of the routing now I'm realizing. But let me know what you think of these changes. You'll have to change this when you get the v2 changes in.
There was a problem hiding this comment.
Oh also for reference it seems like its the keccak commitments that don't have a version byte:
eigenda-proxy/server/routing.go
Line 66 in 096003c
samlaf
force-pushed
the
samlaf/fix--middlewares-response-status-code
branch
from
2561326 to
8bd4b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #186
Changes proposed
Screenshots (Optional)
Note to reviewers