Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename client -> SimpleCommitmentClient and add comments #201

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Nov 18, 2024

Fixes Issue

Fixes #184

Changes proposed

Screenshots (Optional)

Note to reviewers

@samlaf samlaf requested review from epociask and bxue-l2 November 18, 2024 16:38
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should we also update the file name (e.g, client/simple.go)?

@samlaf
Copy link
Collaborator Author

samlaf commented Nov 20, 2024

964989d

Yep, done: 964989d

@samlaf samlaf merged commit 0121434 into main Nov 20, 2024
7 checks passed
@samlaf samlaf deleted the samlaf/docs--add-comments-to-explain-simple-client branch November 20, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comments explaining when our client is used instead of the rollup stack's client
2 participants