fix(CI): Add docker build and curl check #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epociask
changed the title
epociask
changed the title
samlaf
approved these changes
Dec 12, 2024
scripts/wait-for.sh
Outdated
| if curl -X GET 'http://localhost:6666/health'; then | ||
| exit 0 | ||
| else | ||
| sleep 20 |
There was a problem hiding this comment.
sleep 2 is prob better? otherwise the ci takes minimum 20seconds given Id assume the first ping is not going to work because container is still being spun up.
scripts/wait-for.sh
Outdated
Comment on lines
2
to
3
| # poll the proxy endpoint until we get a 0 return code or 5mins have passed, in that case exit 1 | ||
| timeout_time=$(($(date +%s) + 300)) |
There was a problem hiding this comment.
prob 2 mins is enough? I personally prefer cis to crash fast and I can restart them manually (restarting on a separate machine might also fix a problem if it was github/azure related)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
Introduces a new CI job which asserts that the server can be built into a docker container. The job also ensures that the health endpoint can be successfully pinged. This is done to avoid regressions where container builds fail on main when publishing to ghcr.