Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the unit test of dataapi serverv2 #1106

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Refactor the unit test of dataapi serverv2 #1106

merged 1 commit into from
Jan 14, 2025

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Jan 14, 2025 •
edited
Loading

Why are these changes needed?

Currently there are code duplication which is bad

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from dmanc and ian-shim January 14, 2025 16:46
@jianoaix jianoaix merged commit 17300a3 into Layr-Labs:master Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

@dmanc dmanc Awaiting requested review from dmanc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @ian-shim