Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility function to call verifyBlobV2 #1107

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Jan 14, 2025

Why are these changes needed?

  • Recent discussions have yielded consensus that the eigenDA cert which gets published to rollup inboxes should contain the NonSignerStakesAndSignature, rather than the SignedBatch
  • This PR introduces a verification utility to call VerifyBlobV2, which accepts the NonSignerStakesAndSignature
  • It's possible that the VerifyBlobV2FromSignedBatch verification utility will be deleted at some point, but I think it makes sense to keep for now, until the v2 client implementation has solidified.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@litt3 litt3 self-assigned this Jan 14, 2025
@litt3 litt3 marked this pull request as ready for review January 14, 2025 19:19
Comment on lines 82 to 83
//
// It is the responsibility of the caller to configure a timeout on the ctx, if a timeout is required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence possibly not necessary, as this behavior is more or less the status-quo of a golang function that accepts a context as an argument but does not have a timeout parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants