Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve blob feed cursor key and add unit test #1113

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Improve blob feed cursor key and add unit test #1113

merged 1 commit into from
Jan 15, 2025
+209 −15

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Jan 15, 2025 •
edited
Loading

Warning

We do not accept trivial/documentation fixes from first-time contributors. These PRs will be closed without review.

Why are these changes needed?

  • Improve blob feed cursor key encoding: from "bytes -> hex -> hex" to "bytes -> hex"
  • Add decoding function (needed for dataapi)
  • Add unit test

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from dmanc January 15, 2025 17:16
@jianoaix jianoaix requested a review from pschork January 15, 2025 19:56
@jianoaix jianoaix merged commit bb0fdf2 into Layr-Labs:master Jan 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@pschork pschork Awaiting requested review from pschork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @dmanc