Fbe/parameters in stack #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to skip the local copy before erasing its BSS
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // ensure exception will work as planned | ||
| os_boot(); | ||
|
|
||
| // Global like variable, placed in stack to avoid BSS corruption by the library application | ||
| swap_app_context_t swap_ctx; | ||
| G_swap_ctx = &swap_ctx; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
| #ifdef HAVE_NBGL | ||
| memcpy(&G_previous_cycle_data, &tmp_previous_cycle_data, sizeof(G_previous_cycle_data)); | ||
| #endif | ||
| G_swap_ctx = &swap_ctx; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
fbeutin-ledger
force-pushed
the
fbe/swap_spl_token
branch
2 times, most recently
from
bafbd0f to
291dba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.