-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y333 201224/appflags hex #17
Conversation
…k/include /appflags.h)
To be merged when LedgerHQ/ledger-device-rust-sdk#227 will me merged and new builder deployed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I am a verbose developer, but I really think this code will look way less in a few months and adding a lot of comments as to what we do and why we do it will help us in the long term
Also this swap implementation will be used as reference for other rust swap implementations (including me for boilerplate) so I think we should add much more context comments
@bboilot-ledger @fbeutin-ledger I did some modifications after your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my end it looks good, but let's wait for @fbeutin-ledger feedback since he had many comments.
No description provided.