Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y333 201224/appflags hex #17

Merged
merged 30 commits into from
Jan 16, 2025
Merged

Y333 201224/appflags hex #17

merged 30 commits into from
Jan 16, 2025

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Dec 20, 2024

No description provided.

@yogh333
Copy link
Contributor Author

yogh333 commented Dec 20, 2024

To be merged when LedgerHQ/ledger-device-rust-sdk#227 will me merged and new builder deployed

@yogh333 yogh333 marked this pull request as ready for review January 6, 2025 15:08
@yogh333 yogh333 mentioned this pull request Jan 6, 2025
@yogh333 yogh333 requested a review from fbeutin-ledger January 7, 2025 17:59
src/swap.rs Outdated Show resolved Hide resolved
Copy link

@fbeutin-ledger fbeutin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I am a verbose developer, but I really think this code will look way less in a few months and adding a lot of comments as to what we do and why we do it will help us in the long term
Also this swap implementation will be used as reference for other rust swap implementations (including me for boilerplate) so I think we should add much more context comments

@yogh333
Copy link
Contributor Author

yogh333 commented Jan 14, 2025

@bboilot-ledger @fbeutin-ledger I did some modifications after your comments.
Regarding the fees, they are supposed to be constant for a Transfer action (see https://docs.near.org/concepts/protocol/gas#cost-for-common-actions). So I always return "0.450 Tgas" as fees. Conversion to a $NEAR value is only possible by retrieving the current gas price, as explained here, so it is not possible to display the fees in $NEAR except by taking the floor price (1 Tgas = 0.0001 $NEAR), which thus can be under-estimated.

Copy link

@bboilot-ledger bboilot-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my end it looks good, but let's wait for @fbeutin-ledger feedback since he had many comments.

@yogh333 yogh333 merged commit 47f3a32 into develop Jan 16, 2025
152 checks passed
@yogh333 yogh333 deleted the y333_201224/appflags_hex branch January 16, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants