Skip to content

Commit

Permalink
fix: fix @.amount/@.value confusion (#61)
Browse files Browse the repository at this point in the history
fix "native currency value of the transaction" sometimes referred as `@.amount`, sometimes `@.value`
=> use `@.value` everywhere
  • Loading branch information
jnicoulaud-ledger authored Oct 18, 2024
1 parent d6bda6a commit 025f51d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions registry/lido/calldata-stETH.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"intent": "Stake ETH",
"fields": [
{
"path": "@.amount",
"path": "@.value",
"label": "Amount to Stake",
"format": "amount"
},
Expand All @@ -39,7 +39,7 @@
"format": "addressName"
}
],
"required": ["@.amount"]
"required": ["@.value"]
},
"approve(address,uint256)" : {
"intent": "Approve a spender",
Expand Down
2 changes: 1 addition & 1 deletion specs/erc-7730.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ References to values in the format specification file
* `$.display.definitions.minReceiveAmount` refers to a common definition reused accross fields formatting definition

References to values in the container (here a EVM Tx container)
* `@.amount` refers to the enclosing transaction native currency amount
* `@.value` refers to the enclosing transaction native currency amount
* `@.to` refers to the enclosing transaction destination address (usually, a smartcontract bound to this ERC-7730 through the `context` section)

#### Organizing files
Expand Down

0 comments on commit 025f51d

Please sign in to comment.