Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing parameters for addressName formats #67

Merged
merged 2 commits into from
Oct 23, 2024
+528 −70
Merged

fix: add missing parameters for addressName formats #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d4a1dc
fix: add missing parameters for `addressName` formats
jnicoulaud-ledger Oct 23, 2024
2f862d5
fix: fix Paraswap invalid params
jnicoulaud-ledger Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions ercs/calldata-erc20-tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "../specs/erc7730-v1.schema.json",
"context": {
"contract" : {
"abi": [
Expand Down Expand Up @@ -60,7 +61,16 @@
{
"path": "_to",
"label": "To",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
},
{
"path": "_value",
Expand All @@ -79,7 +89,16 @@
{
"path": "_spender",
"label": "Spender",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
},
{
"path": "_value",
Expand Down
46 changes: 40 additions & 6 deletions ercs/calldata-erc721-nfts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "../specs/erc7730-v1.schema.json",
"context": {
"contract" : {
"abi": [
Expand Down Expand Up @@ -83,15 +84,42 @@
"definitions": {
"from" : {
"label": "From",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
},
"to" : {
"label": "To",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
},
"operator":{
"operator":{
"label": "Operator",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"contract"
],
"sources": [
"local",
"ens"
]
}
},
"tokenId" : {
"label": "NFT",
Expand Down Expand Up @@ -131,12 +159,18 @@
"$id": "setApprovalForAll",
"intent": "Manage operator rights for",
"fields": [
{
{
"path": "@.to",
"label": "Collection",
"format": "addressName",
"params": {
"types": ["collection"]
"types": [
"collection"
],
"sources": [
"local",
"ens"
]
}
},
{ "path": "_operator", "$ref": "$.display.definitions.operator" },
Expand Down
12 changes: 11 additions & 1 deletion ercs/eip712-erc2612-permit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "../specs/erc7730-v1.schema.json",
"context": {
"eip712": {
"schemas": [
Expand Down Expand Up @@ -58,7 +59,16 @@
{
"path": "spender",
"label": "Spender",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"contract"
],
"sources": [
"local",
"ens"
]
}
},
{
"path": "value",
Expand Down
60 changes: 54 additions & 6 deletions registry/aave/calldata-lpv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9#code is likely to be a proxy, validation of descriptor ABIs skipped

Check warning on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

Display field for path `#.referralCode` is missing for selector `0xa415bcad/borrow(address,uint256,uint256,uint16,address)`. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

Display field for path `#.referralCode` is missing for selector `0xe8eda9df/deposit(address,uint256,address,uint16)`. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check notice on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9#code is likely to be a proxy, validation of descriptor ABIs skipped

Check warning on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

Display field for path `#.referralCode` is missing for selector `0xa415bcad/borrow(address,uint256,uint256,uint16,address)`. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/aave/calldata-lpv2.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field 

Display field for path `#.referralCode` is missing for selector `0xe8eda9df/deposit(address,uint256,address,uint16)`. If intentionally excluded, please add it to `excluded` list to avoid this warning.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low Wiz Data Finding

Details
Data Classifier Financial/Ethereum Address
Data Classifier ID BUILTIN-388
Data Category Financial

Sampled Examples

Key Value
ethereum 0x*17...**57 (42 chars)
ethereum 0x*34...**45 (42 chars)
ethereum 0x*76...**a9 (42 chars)
ethereum 0x*9c...**a0 (42 chars)
ethereum 0x*ab...**84 (42 chars)

"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "Lending Pool v2",
Expand Down Expand Up @@ -58,7 +58,16 @@
{
"path": "onBehalfOf",
"format": "addressName",
"label": "For debt holder"
"label": "For debt holder",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["amount", "rateMode", "onBehalfOf"]
Expand All @@ -71,7 +80,13 @@
"format": "addressName",
"label": "For asset",
"params": {
"types": ["token"]
"types": [
"token"
],
"sources": [
"local",
"ens"
]
}
},
{
Expand All @@ -98,7 +113,16 @@
{
"path": "to",
"format": "addressName",
"label": "To recipient"
"label": "To recipient",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["amount", "to"]
Expand All @@ -111,7 +135,13 @@
"format": "addressName",
"label": "For asset",
"params": {
"types": ["token"]
"types": [
"token"
],
"sources": [
"local",
"ens"
]
}
},
{
Expand Down Expand Up @@ -147,7 +177,16 @@
{
"path": "onBehalfOf",
"format": "addressName",
"label": "Debtor"
"label": "Debtor",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["amount", "onBehalfOf", "interestRateMode"]
Expand All @@ -167,7 +206,16 @@
{
"path": "onBehalfOf",
"format": "addressName",
"label": "Collateral recipient"
"label": "Collateral recipient",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["amount", "onBehalfOf"]
Expand Down
77 changes: 70 additions & 7 deletions registry/lido/calldata-OssifiableProxy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.wstETHaddress must be absolute, please change it to #.0x0B925eD163218f6662a35e0f0371Ac234f9E9371. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.wstETHaddress must be absolute, please change it to #.0x0B925eD163218f6662a35e0f0371Ac234f9E9371. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.stETHaddress must be absolute, please change it to #.0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.stETHaddress must be absolute, please change it to #.0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check notice on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0x889edC2eDab5f40e902b864aD4d7AdE8E412F9B1#code is likely to be a proxy, validation of descriptor ABIs skipped

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.wstETHaddress must be absolute, please change it to #.0x0B925eD163218f6662a35e0f0371Ac234f9E9371. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.wstETHaddress must be absolute, please change it to #.0x0B925eD163218f6662a35e0f0371Ac234f9E9371. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.stETHaddress must be absolute, please change it to #.0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check failure on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Invalid data path constant 

Data path defined at $.metadata.constants.stETHaddress must be absolute, please change it to #.0xae7ab96520DE3A18E5e111B5EaAb095312D7fE84. If your intention was to define a literal constant rather than a data path, please note this feature is not supported.

Check notice on line 1 in registry/lido/calldata-OssifiableProxy.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Proxy contract 

Contract https://etherscan.io/address/0x889edC2eDab5f40e902b864aD4d7AdE8E412F9B1#code is likely to be a proxy, validation of descriptor ABIs skipped
"$schema": "../../specs/erc7730-v1.schema.json",

"context": {
Expand Down Expand Up @@ -43,7 +43,16 @@
{
"path": "_owner",
"label": "Beneficiary",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["_amounts", "_owner"]
Expand All @@ -62,7 +71,16 @@
{
"path": "_owner",
"label": "Beneficiary",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["_amounts", "_owner"],
Expand All @@ -82,7 +100,16 @@
{
"path": "_owner",
"label": "Beneficiary",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["_amounts", "_owner"]
Expand All @@ -101,7 +128,16 @@
{
"path": "_owner",
"label": "Beneficiary",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["_amounts", "_owner"],
Expand All @@ -118,7 +154,16 @@
{
"path": "@.from",
"label": "Beneficiary",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["_requestId", "@.from"]
Expand All @@ -134,7 +179,16 @@
{
"path": "@.from",
"label": "Beneficiary",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["_requestIds", "@.from"],
Expand All @@ -151,7 +205,16 @@
{
"path": "_recipient",
"label": "Beneficiary",
"format": "addressName"
"format": "addressName",
"params": {
"types": [
"eoa"
],
"sources": [
"local",
"ens"
]
}
}
],
"required": ["_requestIds", "_recipient"],
Expand Down
Loading
Loading