Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new workflow to test updated nightly #119

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Jan 17, 2024

No description provided.

path: app-boilerplate/build/*
if-no-files-found: error

ragger_tests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to run this in the dev-tools image (not the regular app-builder, it doesn't have Ragger nor Speculos)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall be fixed in reusable_ragger_tests flow as it uses ubuntu-latest nowadays.

Copy link
Contributor

@agrojean-ledger agrojean-ledger Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird to use ubuntu-latest and then do

      - name: Install tests dependencies
        run: |
          sudo apt-get update && sudo apt-get install -y qemu-user-static tesseract-ocr libtesseract-dev
          pip install -U pip setuptools
          pip install -r "${{ needs.call_get_app_metadata.outputs.pytest_directory }}/requirements.txt"

in the reusable workflow... Maybe it's because we want to be closer to a real host environment ? 🤔

We wouldn't need the Install tests dependencies if we used the app-dev-tools

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see LedgerHQ/ledger-app-workflows#56, I do not know why an ubuntu env is used to run test (rather than our dev-tools container)...

@yogh333 yogh333 marked this pull request as ready for review January 17, 2024 17:00
@yogh333 yogh333 merged commit 6c4ecec into master Jan 18, 2024
22 checks passed
@yogh333 yogh333 deleted the feat/test_updated_nightly branch January 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants