Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap review #233

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Swap review #233

merged 5 commits into from
Jan 16, 2025

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Jan 15, 2025

No description provided.

bboilot-ledger
bboilot-ledger reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@bboilot-ledger bboilot-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one last point on my side, otherwise it looks good to me!

ledger_device_sdk/src/libcall/swap.rs Show resolved Hide resolved
@yogh333 yogh333 merged commit a290ffe into master Jan 16, 2025
43 of 44 checks passed
@yogh333 yogh333 deleted the y333_150124/swap_sdk_review branch January 16, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboilot-ledger bboilot-ledger bboilot-ledger approved these changes

@fbeutin-ledger fbeutin-ledger Awaiting requested review from fbeutin-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogh333 @bboilot-ledger