-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App loading with more features #69
Conversation
Intended benefits - More parallelism - Failures are clearer at a glance
abbc6d4
to
abd2e42
Compare
1. Relocations are performed, obviating the need for manual `pic` sprinkling. 2. Globals with initial values (vs all-0 globals in BSS) are now initialized to those values.
abd2e42
to
941fb47
Compare
Thanks for this landmark contribution! |
We actually do use |
Ok, then this is a 'nice' option for cross-platform building, but would be really nice if that wasn't even necessary. I recall you mentioned trying to have a section containing relocations directly in the linker script does not work @Ericson2314 , because then it's also considered something to relocate and trouble ensues. Do you have a link to anything that mentions this problem? Even if it points into LLVM's source code, I'm ready 😄 |
…ss multiple runs The `pic` API can only detect the linked code addresses, and in principle cannot help if the app's flash storage has been moved after the relocations had been already applied. This fix does the relocations by storing the _nvram value and comparing it across multiple app runs to detect changes.
The problem with doing the "link-wrap" phase in the cargo ledger is that the |
Yes agreed! So I just need to find a way to execute those commands in Windows properly, but having a Your PR is great, I'm just unclear on why we can't have the |
See #128 |
Relocations are performed, obviating the need for manual
pic
sprinkling.Globals with initial values (vs all-0 globals in BSS) are now initialized to those values.
Contains #68, though if that PR is not wanted this is easy to undo.