Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New elf metadata from C SDK. #96

Merged
merged 7 commits into from
Nov 24, 2023
Merged

New elf metadata from C SDK. #96

merged 7 commits into from
Nov 24, 2023

Conversation

agrojean-ledger
Copy link
Contributor

@agrojean-ledger agrojean-ledger commented Nov 22, 2023 •
edited
Loading

Dynamically retrieve C SDK infos and store them in the ELF

@agrojean-ledger agrojean-ledger requested review from yhql, yogh333, kingofpayne and xchapron-ledger and removed request for yogh333 November 22, 2023 13:24
@agrojean-ledger agrojean-ledger mentioned this pull request Nov 22, 2023
Closed
xchapron-ledger
xchapron-ledger reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on app build and Speculos, it works well!

Do not forget to bump the crate versions.

ledger_secure_sdk_sys/build.rs Outdated Show resolved Hide resolved
ledger_secure_sdk_sys/build.rs Outdated Show resolved Hide resolved
ledger_secure_sdk_sys/build.rs Show resolved Hide resolved
xchapron-ledger
xchapron-ledger reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok on Speculos on all devices.

ledger_secure_sdk_sys/src/infos.rs Show resolved Hide resolved
@agrojean-ledger agrojean-ledger merged commit 27ad410 into master Nov 24, 2023
10 checks passed
@agrojean-ledger agrojean-ledger deleted the update-app-metadata-2 branch November 24, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger left review comments

@yhql yhql yhql approved these changes

@kingofpayne kingofpayne Awaiting requested review from kingofpayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrojean-ledger @yhql @xchapron-ledger