auth in workflow instead of action

LedgerHQ · Jan 16, 2025 · 610ae6b · 610ae6b
1 parent 5fa7ec7
commit 610ae6b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/generate-screenshots.yml b/.github/workflows/generate-screenshots.yml
@@ -39,6 +39,11 @@ jobs:
       PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
     runs-on: [ledger-live-4xlarge]
     steps:
+      - name: Docker Hub Login
+        uses: docker/login-action@v2
+        with:
+          username: ${{ secrets.DOCKER_HUB_USERNAME }}
+          password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
       - name: generate token
         id: generate-token
         uses: tibdex/github-app-token@v1

diff --git a/tools/actions/composites/update-snapshots-desktop/action.yml b/tools/actions/composites/update-snapshots-desktop/action.yml
@@ -11,12 +11,6 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Docker Hub Login
-      uses: docker/login-action@v2
-      with:
-        username: ${{ secrets.DOCKER_HUB_USERNAME }}
-        password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
-
     - name: Update playwright snapshots [Linux => xvfb-run]
       if: ${{ startsWith(inputs.os, 'ubuntu') }}
       run: |