Merge pull request #8800 from LedgerHQ/support/QAA-405

[QAA] Update Swap tests to always choose valid provider

.changeset/tame-geese-thank.md

@@ -0,0 +1,6 @@
+---
+"ledger-live-desktop": minor
+"@ledgerhq/live-common": minor
+---
+
+test: Refactoring of the Swap Enum + updating Provider Selection + Updating device for e2e tests

apps/ledger-live-desktop/src/renderer/reducers/devices.ts

@@ -69,30 +69,38 @@ export function getCurrentDevice(state: { devices: DevicesState; settings: Setti
     };
   }
 
-  if (
-    getEnv("DEVICE_PROXY_URL") ||
-    getEnv("SPECULOS_API_PORT") ||
-    (getEnv("MOCK") && !getEnv("MOCK_NO_BYPASS"))
-  ) {
-    // bypass the listen devices (we should remove modelId here by instead get it at open time if needed)
-    return {
-      deviceId: "",
-      wired: true,
-      modelId: DeviceModelId.nanoS,
-    };
+  const envConditions = [
+    { condition: getEnv("DEVICE_PROXY_URL"), modelId: DeviceModelId.nanoS },
+    { condition: getEnv("MOCK") && !getEnv("MOCK_NO_BYPASS"), modelId: DeviceModelId.nanoS },
+    { condition: getEnv("SPECULOS_API_PORT"), modelId: DeviceModelId.nanoSP },
+  ];
+
+  for (const { condition, modelId } of envConditions) {
+    if (condition) {
+      return {
+        deviceId: "",
+        wired: true,
+        modelId,
+      };
+    }
   }
   return state.devices.currentDevice;
 }
 export function getDevices(state: { devices: DevicesState }) {
-  if (getEnv("DEVICE_PROXY_URL") || getEnv("SPECULOS_API_PORT")) {
-    // bypass the listen devices
-    return [
-      {
-        deviceId: "",
-        wired: true,
-        modelId: DeviceModelId.nanoS,
-      },
-    ];
+  const envConditions = [
+    { condition: getEnv("DEVICE_PROXY_URL"), modelId: DeviceModelId.nanoS },
+    { condition: getEnv("SPECULOS_API_PORT"), modelId: DeviceModelId.nanoSP },
+  ];
+  for (const { condition, modelId } of envConditions) {
+    if (condition) {
+      return [
+        {
+          deviceId: "",
+          wired: true,
+          modelId,
+        },
+      ];
+    }
   }
   return state.devices.devices;
 }

apps/ledger-live-desktop/tests/page/drawer/send.drawer.ts

@@ -2,6 +2,7 @@ import { step } from "tests/misc/reporters/step";
 import { Drawer } from "tests/component/drawer.component";
 import { expect } from "@playwright/test";
 import { NFTTransaction, Transaction } from "@ledgerhq/live-common/e2e/models/Transaction";
+import { TransactionStatus } from "@ledgerhq/live-common/e2e/enum/TransactionStatus";
 
 export class SendDrawer extends Drawer {
   private addressValue = (address: string) =>
@@ -24,7 +25,7 @@ export class SendDrawer extends Drawer {
   @step("Verify Send NFT information")
   async expectNftInfos(tx: NFTTransaction) {
     const transactionType = await this.transactionType.textContent();
-    expect(transactionType).toMatch("Sending");
+    expect(transactionType).toMatch(TransactionStatus.SENDING);
     const NFTName = await this.nftName.textContent();
     expect(NFTName).toBe(tx.nft.nftName);
     const address = await this.addressValue(tx.accountToCredit.address).textContent();

apps/ledger-live-desktop/tests/page/drawer/swap.confirmation.drawer.ts

@@ -1,7 +1,6 @@
 import { expect } from "@playwright/test";
 import { step } from "tests/misc/reporters/step";
 import { Drawer } from "tests/component/drawer.component";
-import { capitalizeFirstLetter } from "tests/utils/textParserUtils";
 
 export class SwapConfirmationDrawer extends Drawer {
   private amountSent = this.page.getByTestId("amountSent");
@@ -26,7 +25,7 @@ export class SwapConfirmationDrawer extends Drawer {
 
   @step("Verify provider: $0")
   async verifyProvider(provider: string) {
-    await expect(this.swapProvider).toHaveText(capitalizeFirstLetter(provider));
+    await expect(this.swapProvider).toHaveText(provider);
   }
 
   @step("Verify source currency: $0")

apps/ledger-live-desktop/tests/page/swap.page.ts

@@ -2,9 +2,9 @@ import { AppPage } from "tests/page/abstractClasses";
 import { waitFor } from "../utils/waitFor";
 import { step } from "tests/misc/reporters/step";
 import { ElectronApplication, expect } from "@playwright/test";
-import { capitalizeFirstLetter } from "tests/utils/textParserUtils";
 import { Account } from "@ledgerhq/live-common/e2e/enum/Account";
 import { ChooseAssetDrawer } from "tests/page/drawer/choose.asset.drawer";
+import { Provider } from "@ledgerhq/live-common/e2e/enum/Swap";
 
 export class SwapPage extends AppPage {
   private currencyByName = (accountName: string) => this.page.getByText(accountName); // TODO: this is rubbish. Changed this
@@ -35,12 +35,6 @@ export class SwapPage extends AppPage {
   private advancedFeesSelector = this.page.getByTestId("advanced-fee-mode-selector");
   private customFeeTextbox = this.page.getByTestId("currency-textbox");
 
-  // Quote Components
-  private quoteContainer = (providerName: string, exchangeType: string) =>
-    this.page.getByTestId(`quote-container-${providerName}-${exchangeType}`);
-  private quoteSelector = (providerName: string, rate: string) =>
-    `quote-container-${providerName}-${rate}`;
-
   // Exchange Button Component
   private exchangeButton = this.page.getByTestId("exchange-button");
 
@@ -116,16 +110,34 @@ export class SwapPage extends AppPage {
     await this.customFeeTextbox.fill(amount);
   }
 
-  @step("Select exchange quote $0 with rate $1")
-  async selectExchangeQuote(providerName: string, exchangeType: "fixed" | "float") {
-    await this.quoteContainer(providerName, exchangeType).click();
-  }
-
-  @step("Select exchange quote with provider $1")
-  async selectQuote(electronApp: ElectronApplication, providerName: string, rate: string) {
+  @step("Select available provider")
+  async selectExchange(electronApp: ElectronApplication) {
     const [, webview] = electronApp.windows();
-    await expect(webview.getByTestId(this.quoteSelector(providerName, rate))).toBeEnabled();
-    await webview.getByTestId(this.quoteSelector(providerName, rate)).click();
+    await expect(webview.getByTestId("number-of-quotes")).toBeVisible();
+    const providersList = await webview
+      .locator("//span[@data-testid='quote-card-provider-name']")
+      .allTextContents();
+
+    const providersWithoutKYC = providersList.filter(providerName => {
+      const provider = Object.values(Provider).find(p => p.uiName === providerName);
+      return provider && !provider.kyc;
+    });
+
+    for (const providerName of providersWithoutKYC) {
+      const provider = Object.values(Provider).find(p => p.uiName === providerName);
+      if (provider && provider.isNative) {
+        const providerLocator = webview
+          .locator(`//span[@data-testid='quote-card-provider-name' and text()='${providerName}']`)
+          .first();
+
+        await providerLocator.isVisible();
+        await providerLocator.click();
+
+        return providerName;
+      }
+    }
+
+    throw new Error("No valid providers found");
   }
 
   async waitForExchangeToBeAvailable() {
@@ -135,7 +147,7 @@ export class SwapPage extends AppPage {
   @step("Click Exchange button")
   async clickExchangeButton(electronApp: ElectronApplication, provider: string) {
     const [, webview] = electronApp.windows();
-    await webview.getByText(`Swap with ${capitalizeFirstLetter(provider)}`).click();
+    await webview.getByText(`Swap with ${provider}`).click();
   }
 
   async confirmExchange() {

apps/ledger-live-desktop/tests/specs/speculos/delegate.spec.ts

@@ -5,6 +5,7 @@ import { addTmsLink, addBugLink } from "tests/utils/allureUtils";
 import { getDescription } from "../../utils/customJsonReporter";
 import { CLI } from "tests/utils/cliUtils";
 import { Currency } from "@ledgerhq/live-common/e2e/enum/Currency";
+import { getEnv } from "@ledgerhq/live-env";
 
 const e2eDelegationAccounts = [
   {
@@ -106,9 +107,11 @@ test.describe("Delegate flows", () => {
           await app.delegateDrawer.amountValueIsVisible();
           await app.drawer.close();
 
-          await app.layout.syncAccounts();
-          await app.account.clickOnLastOperation();
-          await app.delegateDrawer.expectDelegationInfos(account.delegate);
+          if (!getEnv("DISABLE_TRANSACTION_BROADCAST")) {
+            await app.layout.syncAccounts();
+            await app.account.clickOnLastOperation();
+            await app.delegateDrawer.expectDelegationInfos(account.delegate);
+          }
         },
       );
     });

apps/ledger-live-desktop/tests/specs/speculos/send.tx.spec.ts

@@ -1,7 +1,7 @@
 import { test } from "../../fixtures/common";
 import { Account } from "@ledgerhq/live-common/e2e/enum/Account";
 import { Fee } from "@ledgerhq/live-common/e2e/enum/Fee";
-import { OperationType } from "@ledgerhq/live-common/e2e/enum/OperationType";
+import { TransactionStatus } from "@ledgerhq/live-common/e2e/enum/TransactionStatus";
 import { Transaction } from "@ledgerhq/live-common/e2e/models/Transaction";
 import { addTmsLink, addBugLink } from "tests/utils/allureUtils";
 import { getDescription } from "../../utils/customJsonReporter";
@@ -273,7 +273,6 @@ test.describe("Send flows", () => {
             transaction.transaction.accountToCredit.address,
           );
           await app.drawer.close();
-          // Todo: Update method => Check the receiver account only when we broadcast
           if (!getEnv("DISABLE_TRANSACTION_BROADCAST")) {
             await app.layout.goToAccounts();
             await app.accounts.clickSyncBtnForAccount(
@@ -282,7 +281,7 @@ test.describe("Send flows", () => {
             await app.accounts.navigateToAccountByName(
               transaction.transaction.accountToCredit.accountName,
             );
-            await app.account.selectAndClickOnLastOperation(OperationType.RECEIVED);
+            await app.account.selectAndClickOnLastOperation(TransactionStatus.RECEIVED);
             await app.sendDrawer.expectReceiverInfos(transaction.transaction);
           }
         },