Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-347] Adding NFT e2e tests #8577

Merged
merged 3 commits into from
Dec 9, 2024
Merged

[QAA-347] Adding NFT e2e tests #8577

merged 3 commits into from
Dec 9, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Dec 3, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Adding e2e tests

📝 Description

  1. Adding 3 e2e tests for NFT:
  • The user displays his nft collection
  • The user displays all the nfts from his account
  • The user can see his NFT floor price

  1. Updating Send NFT to ENS address

  2. Creating NftGallery page + NFT enum

  3. Adding data-testId

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:56am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:56am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:56am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:56am

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Dec 3, 2024
@VicAlbr VicAlbr force-pushed the support/qaa-347 branch 2 times, most recently from 99627a1 to ee5ac57 Compare December 4, 2024 14:54
@VicAlbr VicAlbr marked this pull request as ready for review December 4, 2024 14:56
@VicAlbr VicAlbr requested review from a team as code owners December 4, 2024 14:56
themooneer
themooneer approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VicAlbr VicAlbr merged commit 6cd0ff1 into develop Dec 9, 2024
55 checks passed
@VicAlbr VicAlbr deleted the support/qaa-347 branch December 9, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdurrahman-ledger abdurrahman-ledger abdurrahman-ledger approved these changes

@themooneer themooneer themooneer approved these changes

@ypolishchuk-ledger ypolishchuk-ledger Awaiting requested review from ypolishchuk-ledger

Assignees

@VicAlbr VicAlbr

Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VicAlbr @themooneer @ypolishchuk-ledger @abdurrahman-ledger