coin module boilerplate #8809
Merged
coin module boilerplate #8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Wozacosta
force-pushed
the
support/coin-module-boilerplate-BACKUP
branch
from
35754b0 to
173a832
Compare
Wozacosta
force-pushed
the
support/coin-module-boilerplate-BACKUP
branch
from
173a832 to
49fff17
Compare
Wozacosta
force-pushed
the
support/coin-module-boilerplate-BACKUP
branch
from
92f0383 to
40aac8f
Compare
Wozacosta
force-pushed
the
support/coin-module-boilerplate-BACKUP
branch
from
01e8288 to
5fb5d61
Compare
Wozacosta
force-pushed
the
support/coin-module-boilerplate-BACKUP
branch
from
c03af53 to
5ade914
Compare
| import { parseCurrencyUnit } from "@ledgerhq/coin-framework/currencies"; | ||
| import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets/currencies"; | ||
|
|
||
| const rippleUnit = getCryptoCurrencyById("ripple").units[0]; |
There was a problem hiding this comment.
Couldn't simply change it to boilerplate as it throws an error then. I've put up a comment just above this line:
4eefcce
There was a problem hiding this comment.
I think we can @ts-ignore it, code won't run for real
There was a problem hiding this comment.
It's ran for some unit tests, for example: https://github.com/LedgerHQ/ledger-live/actions/runs/12806166264/job/35704074323?pr=8809
libs/coin-modules/coin-module-boilerplate/src/test/bot-specs.ts
Outdated
Show resolved
Hide resolved
Wozacosta
force-pushed
the
support/coin-module-boilerplate-BACKUP
branch
from
afb8b43 to
28b345b
Compare
hedi-edelbloute
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
A skeleton for a coin module (like Apps team do)
❓ Context
🧐 Checklist for the PR Reviewers