Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/mev protection walletapi #8829

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Feat/mev protection walletapi #8829

merged 8 commits into from
Jan 10, 2025

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Jan 7, 2025 •
edited
Loading

⚠️ Depend on LedgerHQ/wallet-api#418, which is merged.

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Wozacosta Wozacosta requested a review from a team as a code owner January 7, 2025 10:49
@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 1:27pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 1:27pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 1:27pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 1:27pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Jan 7, 2025
@Wozacosta Wozacosta mentioned this pull request Jan 7, 2025
Merged
@Wozacosta Wozacosta marked this pull request as draft January 7, 2025 10:53
@Wozacosta Wozacosta force-pushed the feat/mev-protection-walletapi branch from 090baca to 67f6e62 Compare January 7, 2025 18:06
@Wozacosta Wozacosta marked this pull request as ready for review January 7, 2025 18:56
ComradeAERGO
ComradeAERGO previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, wish we done this from the start of this US

@Wozacosta Wozacosta merged commit 108556d into develop Jan 10, 2025
54 of 55 checks passed
@Wozacosta Wozacosta deleted the feat/mev-protection-walletapi branch January 10, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canestin Canestin Canestin approved these changes

@ComradeAERGO ComradeAERGO ComradeAERGO approved these changes

Assignees

@Wozacosta Wozacosta

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wozacosta @ComradeAERGO @Canestin