feat 💄(llm) Reborn Upsell Flex Drawer #8843

LucasWerey · 2025-01-08T14:13:47Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- hardcoded lnx "drawer" screen

📝 Description

Under ff create hardcoded Flex upsell drawer screen. This will allows us to replace the current lnx drawer. Also it works with the dynamic Reborn_LP. So it will fallback to it if needed.
The upsell redirection is defined in a feature flag that's why in the video it redirects to LNX page and not flex.
I haven't done any major changes and kept the same pattern

Also we need to allow ledger-shop to be usable even in Reborn mode

All use cases :
https://github.com/user-attachments/assets/0f70a9e3-f1a1-42a3-935c-47a8223d8d5e

Dark mode :
https://github.com/user-attachments/assets/7e53e0ee-66ee-424c-85c9-d9042ce99cd2

❓ Context

JIRA or GitHub link: LIVE-15654

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2025-01-08T14:13:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	❌ Failed (Inspect)			Jan 16, 2025 9:09am

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Jan 16, 2025 9:09am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 16, 2025 9:09am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 16, 2025 9:09am

mcayuelas-ledger · 2025-01-15T09:30:54Z

apps/ledger-live-mobile/assets/videos/index.ts

@@ -10,4 +10,5 @@ export default {
  infinityPassPart02Light: require("./infinityPassLight/infinityPassPart02.mp4"),
  customLockScreenBannerLight: require("./customLockScreenBanner/customLockScreenBannerLight.mp4"),
  customLockScreenBannerDark: require("./customLockScreenBanner/customLockScreenBannerDark.mp4"),
+  flex: require("./flex.mp4"),


maybe we can create a dedicated folder for Flex?

mcayuelas-ledger · 2025-01-15T09:31:20Z

apps/ledger-live-mobile/src/components/RootNavigator/BaseNavigator.tsx

@@ -209,7 +209,6 @@ export default function BaseNavigator() {
          options={{
            headerStyle: styles.headerNoShadow,
          }}
-          {...noNanoBuyNanoWallScreenOptions}


Are we sure we want to remove this wall?

I remove it from here but I catch it directly inside the screen where we call the discovery app so IMO it's ok the behaviour doesn't change and let me be able to open the ledger shop in reborn mode

mcayuelas-ledger · 2025-01-15T09:31:46Z

apps/ledger-live-mobile/src/locales/en/common.json

@@ -1303,7 +1303,7 @@
      "desc": "Our products are the only hardware wallets certified for their security by national cyber security agencies."
    },
    "title": "You need a Ledger",
-    "desc": "For your security, Ledger Live only works with a device. You need a device in order to continue.",
+    "desc": "For your security,\n Ledger Live only works with a Ledger.",


\n working here?

mcayuelas-ledger

As it's a new feature in new Arch, it's possible to try to make a quick test?

mcayuelas-ledger · 2025-01-16T08:53:11Z

...ger-live-mobile/src/newArch/features/Reborn/__integrations__/upSellFlex.integration.test.tsx

+const Stack = createStackNavigator();
+
+const MockComponent = () => (
+  <OnboardingContextProvider>
+    <Stack.Navigator>
+      <Stack.Screen name="UpsellFlex" component={UpsellFlex} />
+    </Stack.Navigator>
+  </OnboardingContextProvider>
+);


You can put this on a shared file :)

semeano · 2025-01-16T10:03:03Z

apps/ledger-live-mobile/src/locales/en/common.json

@@ -1303,7 +1303,7 @@
      "desc": "Our products are the only hardware wallets certified for their security by national cyber security agencies."
    },
    "title": "You need a Ledger",
-    "desc": "For your security, Ledger Live only works with a device. You need a device in order to continue.",
+    "desc": "For your security,\n Ledger Live only works with a Ledger.",


Suggested change

"desc": "For your security,\n Ledger Live only works with a Ledger.",

"desc": "For your security,\n Ledger Live only works with a Ledger device.",

It's the wording from Figma so I guess it's good

github-actions bot assigned LucasWerey Jan 8, 2025

live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jan 8, 2025

LucasWerey force-pushed the feat/LIVE-15654 branch 3 times, most recently from 1073f42 to f5387ba Compare January 9, 2025 14:14

live-github-bot bot added the common Has changes in live-common label Jan 9, 2025

vercel bot deployed to Preview – web-tools January 9, 2025 14:19 View deployment

LucasWerey force-pushed the feat/LIVE-15654 branch from f5387ba to 0be2682 Compare January 14, 2025 12:11

vercel bot deployed to Preview – web-tools January 14, 2025 12:15 View deployment

LucasWerey force-pushed the feat/LIVE-15654 branch from 0be2682 to 0ad7cdb Compare January 14, 2025 14:19

live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Jan 14, 2025

vercel bot deployed to Preview – web-tools January 14, 2025 14:25 View deployment

LucasWerey force-pushed the feat/LIVE-15654 branch from 0ad7cdb to 5b6ffc0 Compare January 14, 2025 14:34

vercel bot had a problem deploying to Preview – web-tools January 14, 2025 14:36 Failure

LucasWerey force-pushed the feat/LIVE-15654 branch from 5b6ffc0 to cb5ca2d Compare January 14, 2025 14:40

LucasWerey marked this pull request as ready for review January 14, 2025 14:40

LucasWerey requested review from a team as code owners January 14, 2025 14:40

vercel bot had a problem deploying to Preview – web-tools January 14, 2025 14:44 Failure

LucasWerey force-pushed the feat/LIVE-15654 branch from cb5ca2d to 225f1b4 Compare January 14, 2025 15:24

vercel bot had a problem deploying to Preview – web-tools January 14, 2025 15:30 Failure

LucasWerey changed the title ~~feat 💄(llm): update LNX drawer in Reborn~~ feat 💄(llm) Reborn Upsell Flex Drawer Jan 14, 2025

LucasWerey force-pushed the feat/LIVE-15654 branch from 225f1b4 to b650789 Compare January 14, 2025 16:02

vercel bot had a problem deploying to Preview – web-tools January 14, 2025 16:03 Failure

mcayuelas-ledger reviewed Jan 15, 2025

View reviewed changes

LucasWerey force-pushed the feat/LIVE-15654 branch from b650789 to 27fce69 Compare January 15, 2025 14:12

vercel bot had a problem deploying to Preview – web-tools January 15, 2025 14:14 Failure

mcayuelas-ledger reviewed Jan 15, 2025

View reviewed changes

LucasWerey force-pushed the feat/LIVE-15654 branch from 27fce69 to 85dea82 Compare January 15, 2025 17:35

vercel bot had a problem deploying to Preview – web-tools January 15, 2025 17:37 Failure

mcayuelas-ledger reviewed Jan 16, 2025

View reviewed changes

feat 💄(llm): update LNX drawer in Reborn

95bf4d2

LucasWerey force-pushed the feat/LIVE-15654 branch from 85dea82 to 95bf4d2 Compare January 16, 2025 09:06

vercel bot had a problem deploying to Preview – web-tools January 16, 2025 09:09 Failure

mcayuelas-ledger approved these changes Jan 16, 2025

View reviewed changes

Wozacosta approved these changes Jan 16, 2025

View reviewed changes

semeano reviewed Jan 16, 2025

View reviewed changes

LucasWerey merged commit 79489d7 into develop Jan 16, 2025
52 of 55 checks passed

LucasWerey deleted the feat/LIVE-15654 branch January 16, 2025 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat 💄(llm) Reborn Upsell Flex Drawer #8843

feat 💄(llm) Reborn Upsell Flex Drawer #8843

LucasWerey commented Jan 8, 2025 •

edited

Loading

vercel bot commented Jan 8, 2025 •

edited

Loading

mcayuelas-ledger Jan 15, 2025

LucasWerey Jan 15, 2025

mcayuelas-ledger Jan 15, 2025

LucasWerey Jan 15, 2025

mcayuelas-ledger Jan 15, 2025

LucasWerey Jan 15, 2025

mcayuelas-ledger left a comment

mcayuelas-ledger Jan 16, 2025

semeano Jan 16, 2025

LucasWerey Jan 16, 2025

	"desc": "For your security,\n Ledger Live only works with a Ledger.",
	"desc": "For your security,\n Ledger Live only works with a Ledger device.",

feat 💄(llm) Reborn Upsell Flex Drawer #8843

feat 💄(llm) Reborn Upsell Flex Drawer #8843

Conversation

LucasWerey commented Jan 8, 2025 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcayuelas-ledger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LucasWerey commented Jan 8, 2025 •

edited

Loading

vercel bot commented Jan 8, 2025 •

edited

Loading