Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not put the selected validator as first on the list #8885

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Jan 13, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Screen.Recording.2025-01-13.at.17.55.42.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jan 13, 2025 4:55pm
native-ui-storybook ⬜️ Ignored (Inspect) Jan 13, 2025 4:55pm
react-ui-storybook ⬜️ Ignored (Inspect) Jan 13, 2025 4:55pm
web-tools ⬜️ Ignored (Inspect) Jan 13, 2025 4:55pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 13, 2025
@qperrot qperrot marked this pull request as ready for review January 15, 2025 07:56
@qperrot qperrot requested a review from a team as a code owner January 15, 2025 07:56
@qperrot qperrot merged commit 04af7d7 into develop Jan 15, 2025
44 of 50 checks passed
@qperrot qperrot deleted the bugfix/cardano-selected-show-all branch January 15, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants