Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-425][Detox][Speculos] Add possibility to target production firebase env #8903

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

abdurrahman-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Detox tests and CI

📝 Description

In order to test pre-release builds we need to add the possibility to run tests targeting firebase production env.

❓ Context

  • Detox mocked run
  • Detox Speculos production run

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@abdurrahman-ledger abdurrahman-ledger requested a review from a team January 15, 2025 08:21
@abdurrahman-ledger abdurrahman-ledger requested a review from a team as a code owner January 15, 2025 08:22
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 8:33am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 8:33am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 8:33am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 8:33am

@live-github-bot live-github-bot bot added mobile Has changes in LLM automation CI/CD stuff labels Jan 15, 2025
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_425_detox_speculos_production branch from 0697ddc to 89070b1 Compare January 15, 2025 08:32
@abdurrahman-ledger abdurrahman-ledger merged commit 03b94da into develop Jan 17, 2025
52 of 55 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_425_detox_speculos_production branch January 17, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants