Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
dyk-im
reviewed
Jan 25, 2025
src/main/java/com/example/eatmate/app/domain/report/dto/ReportRequestDto.java
Show resolved
Hide resolved
seokjun01
reviewed
Jan 26, 2025
| .chatMessage(report.getChatMessage()) | ||
| .build(); | ||
| } | ||
|
|
There was a problem hiding this comment.
실제 서비스를 사용함에 있어서 , 위 DTO는 관리자 영역인가요? 아니면 회원 영역인가요?
제가 경험했던 많은 앱에서는 개인이 신고한 회원들 목록을 제공하지 않았던거 같아서 궁금해서 남깁니다!
There was a problem hiding this comment.
이 DTO는 회원 영역입니다! 피그마에 신고 내역 조회에 회원들 목록이 있어 추가하였습니다
seokjun01
reviewed
Jan 26, 2025
|
|
||
| private LocalDateTime time; | ||
| private final String chatMessage; | ||
|
|
There was a problem hiding this comment.
final 추가해주신것 좋은 설계 같습니다!
|
간단하게 궁금한 점 남겨놨습니다 답변 부탁드립니다! |
seokjun01
approved these changes
Jan 26, 2025
dyk-im
approved these changes
Jan 26, 2025
ehs208
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
📣 To Reviewers
수정 사항