Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an inline Instructor Note warning about different flag behaviour #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add an inline Instructor Note warning about different flag behaviour #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions episodes/05-counting-mining.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,16 @@ $ grep -iw hero *a.tsv > results/hero-i.tsv

::::::::::::::::::::::::::::::::::::::::::::::::::

:::::::::::::::::::::::::::::::::::::::::::::::::: instructor

### Watch out for different behaviour of the -E option across systems

Learners may encounter some inconsistent behaviour between operating systems when solving the challenge below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is referring to the next section, it would make sense to move this into that section (as an H3 under the next H2). Right now this positions it as a heading under the previous solution that it isn't related to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @kaitlinnewson. To make sure that I understand correctly: you would prefer the instructor note to appear inside the challenge block it refers to, rather than above it?

`grep -E` on macOS acts like `grep -P` on other platforms.
On Windows and Linux, `grep -E` is halfway between `grep -P` and `grep`: it only does what `grep` can do, but uses Perl-compatible syntax to do it.

:::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

::::::::::::::::::::::::::::::::::::::: challenge

## Searching with regular expressions
Expand Down