-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New metric: LogAUC
#2377
New metric: LogAUC
#2377
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@SkafteNicki, what is missing here to make it land? 🐿️ |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
=======================================
Coverage 69% 69%
=======================================
Files 344 346 +2
Lines 18969 19129 +160
=======================================
+ Hits 13115 13227 +112
- Misses 5854 5902 +48 |
seems one of the needed packages is missing for py3.12 |
@@ -5,3 +5,4 @@ pandas >1.4.0, <=2.2.3 | |||
netcal >1.0.0, <1.4.0 # calibration_error | |||
numpy <2.2.0 | |||
fairlearn # group_fairness | |||
PyTDC ==0.4.1 ; python_version <"3.12" # locauc, temporal_dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop this condition :)
What does this PR do?
Fixes #2304
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2377.org.readthedocs.build/en/2377/