Addon not working with Omega Beta 2

[heccoder]

Describe the Bug

Testing the addon with Omega beta 2, and getting the following errors in the log:

2023-12-29 01:41:06.130 T:5530    error <general>: EXCEPTION: Kodi is not playing any file
2023-12-29 01:41:16.379 T:5530     info <general>: Skipped 192 duplicate messages..
2023-12-29 01:41:16.379 T:5530    error <general>: Themerr: [ERROR]: YDL returned an unexpected error while downloading https://www.youtube.com/watch?v=HeOOgQVmi8o: 'xbmcout' object has no attribute 'isatty'
2023-12-29 01:41:16.429 T:5530    error <general>: EXCEPTION: Kodi is not playing any file

It's able to determine the movie, but fails to play the song. Any ideas?

Expected Behavior

No response

Additional Context

No response

[adamosborne83]

I can second this issue, logs avaliable if required

[ReenigneArcher]

It might be an issue with https://kodi.wiki/view/Add-on:Youtube-dl_Control

It might be an issue with the region of the video.

Can you see that video on YouTube if you open it in your browser? Or is it unavailable?

[heccoder]

I can see the video in my browser, so it's probably the ytdl addon? It got installed and updated after installing Themerr.

[ReenigneArcher]

Yea, it's probably that add-on.

It's a dependency for Themerr.

I opted to use the Kodi supplied version as I thought it would be cleaner.

I'll create a build later that uses the official source though. Would you mind testing it? If so I'll let you know when it's ready.

[heccoder]

Sure! Let me know once it's ready and I'll test.
Thanks!

[ReenigneArcher]

This would be the preferred fix. Let me know if #20 works. Artifact is available here: https://github.com/LizardByte/Themerr-kodi/actions/runs/7359114852?pr=20

[heccoder]

@ReenigneArcher I just tested and it's now working!
Couple of issues I encountered now that the song plays:

• The add-on doesn't seem to respect the timeout settings, I set it to 1 second but it takes 5-6 seconds or more regardless of what is selected as the timeout.
• After I let it play for while and later exit out of the movie page, the song keeps playing until the end, I have to either manually go into the player and stop it, or restart Kodi.

I can gather some logs for you if you need them, but it now plays, you nailed it!

I know this still a new add-on, but not sure if this is something you could implement or consider for future development:

• A setting to set the volume level of the song would be great!
• The screen briefly flashes and displays the loading icon when the song begins to play, could this be avoided? I'm not sure if this one is even possible due to how Kodi works, it might be more a skin setting maybe?

Thank you for work on this!

[ReenigneArcher]

The add-on doesn't seem to respect the timeout settings, I set it to 1 second but it takes 5-6 seconds or more regardless of what is selected as the timeout.

This is due to how long it takes youtube-dl to determine the audio url. I might pre-fetch this in a future release.

After I let it play for while and later exit out of the movie page, the song keeps playing until the end, I have to either manually go into the player and stop it, or restart Kodi.

Once the item is deselected (for the timeout period), the theme should stop playing. If you select another item with a theme it should start playing. You do not need to be on the movie information page for the theme to play, but it will play in the list view.

I personally wanted it to play only in the movie information page, which is how it works with Plex and Jellyfin, but in Kodi selecting a movie starts playing it, and it's kind of annoying to get to the movie information page (must go through context menu... at least on default skin).

A setting to set the volume level of the song would be great!

It's a good idea. Probably possible to add.

The screen briefly flashes and displays the loading icon when the song begins to play, could this be avoided? I'm not sure if this one is even possible due to how Kodi works, it might be more a skin setting maybe?

This one is pretty annoying, I agree. I think it's something specific to each skin, so I'm not sure how to handle that yet. I think tvtunes hacks the existing skin, which I didn't want to do. I would like a way to somehow hide that, and the playing indicator though.

Here are a few of my other ideas for the plugin: #1 (comment)