Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix: import youtube_dl from YoutubeDLWrapper #20

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

ReenigneArcher
Copy link
Member

Description

Kodi has several patches applied for YouTube-DL in the YoutubeDLWrapper which were not being applied when importing youtube_dl directly. Importing from the wrapper will fix any of these various issues.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix-import-youtube_dl-from-YoutubeDLWrapper branch 2 times, most recently from f264c05 to 7160aa0 Compare December 29, 2023 18:48
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea49257) 81.96% compared to head (8905791) 82.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   81.96%   82.13%   +0.16%     
==========================================
  Files          11       11              
  Lines         316      319       +3     
==========================================
+ Hits          259      262       +3     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReenigneArcher ReenigneArcher force-pushed the fix-import-youtube_dl-from-YoutubeDLWrapper branch from 7160aa0 to dde3168 Compare December 29, 2023 18:54
@ReenigneArcher ReenigneArcher force-pushed the fix-import-youtube_dl-from-YoutubeDLWrapper branch from dde3168 to 8905791 Compare December 29, 2023 18:57
@ReenigneArcher ReenigneArcher merged commit 4d576bd into master Dec 29, 2023
13 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-import-youtube_dl-from-YoutubeDLWrapper branch December 29, 2023 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addon not working with Omega Beta 2
1 participant