Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

refactor: remove unused process_movie method #31

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

ReenigneArcher
Copy link
Member

Description

This PR removes the unused _process_movie method. I wanted to have this in a separate PR, instead of #22 so it will be easier to reference the json rpc method if we need to re-implement something similar later.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2f64c7) 84.56% compared to head (8d26e7a) 86.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   84.56%   86.39%   +1.82%     
==========================================
  Files          11       11              
  Lines         324      316       -8     
==========================================
- Hits          274      273       -1     
+ Misses         50       43       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 30, 2023 17:03
@ReenigneArcher ReenigneArcher merged commit 4eca3fd into master Dec 30, 2023
13 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor-remove-unused-process_movie-method branch December 30, 2023 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant