Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

feat: allow adding cookies from the UI directly and fix the ytdl bug #215

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

zdimension
Copy link
Collaborator

Description

Cookies exported from a browser plugin can now be imported directly from the preferences page.

Cookies are now passed to Youtube-DL in a temporary file so writes by Youtube-DL are not saved (this was previously a problem).

Screenshot

(chrome plugin)
image

(prefs page)
image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Contents/Code/youtube_dl_helper.py Outdated Show resolved Hide resolved
Contents/Code/youtube_dl_helper.py Outdated Show resolved Hide resolved
Contents/Code/youtube_dl_helper.py Outdated Show resolved Hide resolved
docs/source/about/troubleshooting.rst Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #215 (60fd8c1) into nightly (aba0560) will decrease coverage by 0.55%.
The diff coverage is 73.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           nightly     #215      +/-   ##
===========================================
- Coverage    67.85%   67.30%   -0.55%     
===========================================
  Files           11       11              
  Lines          815      838      +23     
===========================================
+ Hits           553      564      +11     
- Misses         262      274      +12     
Flag Coverage Δ
Linux 67.30% <73.33%> (-0.55%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/constants.py 85.71% <ø> (-0.40%) ⬇️
Contents/Code/default_prefs.py 100.00% <ø> (ø)
Contents/Code/youtube_dl_helper.py 74.32% <73.33%> (-11.68%) ⬇️

docs/source/about/usage.rst Outdated Show resolved Hide resolved
Contents/Code/youtube_dl_helper.py Outdated Show resolved Hide resolved
ReenigneArcher
ReenigneArcher previously approved these changes Nov 13, 2023
@ReenigneArcher ReenigneArcher merged commit 400052c into LizardByte:nightly Nov 14, 2023
23 checks passed
@zdimension zdimension deleted the update-cookies branch November 14, 2023 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants