This repository has been archived by the owner on Oct 13, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: allow adding cookies from the UI directly and fix the ytdl bug #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
suggested changes
Nov 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## nightly #215 +/- ##
===========================================
- Coverage 67.85% 67.30% -0.55%
===========================================
Files 11 11
Lines 815 838 +23
===========================================
+ Hits 553 564 +11
- Misses 262 274 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ReenigneArcher
suggested changes
Nov 13, 2023
ReenigneArcher
previously approved these changes
Nov 13, 2023
ReenigneArcher
force-pushed
the
update-cookies
branch
from
November 13, 2023 00:33
5fadef2
to
7ef91d4
Compare
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
zdimension
force-pushed
the
update-cookies
branch
from
November 13, 2023 23:01
ab12fb7
to
72e4e63
Compare
This was referenced Dec 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cookies exported from a browser plugin can now be imported directly from the preferences page.
Cookies are now passed to Youtube-DL in a temporary file so writes by Youtube-DL are not saved (this was previously a problem).
Screenshot
(chrome plugin)
(prefs page)
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.